I fixed that PR. Also @stephen pointed out a wording issue in the CI section. Different PR

nice, thought i approved it - do you need anything else from me there to merge?

don't see an option to resolve that convo

It’s not showing mergable.

yeah doesn't look like i'm a required reviewer and it needs an approval from one, plus that comment resolution

OK, I merged it.

Istvan's linkedin link isn't working btw. says unavailable at least

Can you add an issue?

I’ll check it out later, but I don’t want to lose track.

@ibathazi is this your linkedin profile link? https://www.linkedin.com/in/istvan-bathazi/

Ya’ll good with this? https://github.com/Minimum-CD/cd-manifesto/pull/25/files

People are starting to share and I want to fix this.

lgtm

you have a merge conflict though

Let me fix

Fixed

lgtm still

I think there’s a button you aren’t pressing when you approve.

It’s showing blocked for merge still

hmm, not seeing any other option for me. free for a call? https://meet.google.com/hht-keju-zec

i made a pr to fix a couple small things

Merged

Hmm... Yes it should be correct. I will check it later from personal device

added "refactoring databases" book to resources

@jerreck.moody thanks for fixing link

is there any use case to have a build that isn't intended to be idempotent?

So, there is the "immutable" artifacts in there, so that covers a lot of the benefits. I also see that there is a case of diminishing returns when there are several builds per day. The arguments for this were supply chain attacks but even then I think the solution is to NOT reproduce the build with injections.

gotcha, that makes sense